Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup EB Scalar DevTest. #2011

Merged
merged 12 commits into from
Dec 12, 2024
Merged

Setup EB Scalar DevTest. #2011

merged 12 commits into from
Dec 12, 2024

Conversation

skang67
Copy link
Contributor

@skang67 skang67 commented Dec 6, 2024

  1. Setup a scalar advection problem in DevTest/EB_Test.
  2. Added ERF_redistribute to Make.package and the ERF class. (This function is not yet added to ERF_TI_to_substep_fun.H.)

@asalmgren
Copy link
Collaborator

asalmgren commented Dec 7, 2024 •
edited
Loading

Three things:

  1. remove the line xlo.rhotheta = 1 -- that was a mistake on my part. The correct entry is xlo.theta which is already there.
  2. Instead of changing Make.package, please "git mv ERF_redistribute.cpp ERF_Redistribute.cpp"
  3. I'm not sure I understand what you're doing in ERF_Redistribute.cpp -- it seems to me you could remove the function in lines 10-31 then just call the function currently at line 34 inside the MFIter loop in ERF_TI_no_substep.H. Is that where you're going?

@asalmgren asalmgren enabled auto-merge (squash) December 10, 2024 19:02
auto-merge was automatically disabled December 10, 2024 19:05

Head branch was pushed to by a user without write access

@asalmgren asalmgren merged commit 99a6690 into erf-model:development Dec 12, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asalmgren asalmgren asalmgren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skang67 @asalmgren